feat: erc20 evm precompiles #1181
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gregory Hill <[email protected]>
gregdhill
force-pushed
the
feat/evm-precompiles
branch
from
b2eec9e
to
4c8ba8c
Compare
Signed-off-by: Gregory Hill <[email protected]>
gregdhill
commented
Aug 29, 2023
| CurrencyId::LendToken(_) => { | ||
| let mut vec = Vec::new(); | ||
| vec.extend_from_slice(&b"q"[..]); | ||
| vec.extend_from_slice(&loans::UnderlyingAssetId::<T>::get(self)?.name::<T>()?); |
There was a problem hiding this comment.
We should probably disallow recursive currencies in the loans pallet (i.e. underlying cannot be lend token).
gregdhill
commented
Aug 29, 2023
Comment on lines
+41
to
+42
| // NOTE: `name`, `symbol` and `coingecko_id` are not bounded | ||
| // estimate uses 32 bytes each |
There was a problem hiding this comment.
We can fix this once open-web3-stack/open-runtime-module-library#949 is merged
sander2
approved these changes
Sep 6, 2023
| .. | ||
| } => return IsPrecompileResult::Answer { | ||
| is_precompile: true, | ||
| extra_cost: 0, |
There was a problem hiding this comment.
Assuming it is the extra gas used to verify the address is a precompile, Moonbeam has also set this to zero.
| match self { | ||
| LpToken::Token(token) => Some(token.name().as_bytes().to_vec()), | ||
| LpToken::ForeignAsset(foreign_asset_id) => ForeignAssetInfo(*foreign_asset_id).name::<T>(), | ||
| LpToken::StableLpToken(stable_pool_id) => StablePoolInfo(*stable_pool_id).name::<T>(), |
There was a problem hiding this comment.
Maybe we shouldn't include stablelptoken stuff since we don't have that currently anyway? Then we'll be free to change the types if needed (admittedly unlikely)
There was a problem hiding this comment.
We don't have any tokens so I think it is fine to leave as-is for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ERC20 compatible precompile(s) for all currencies at well-known addresses, currently derived using their SCALE encoding.
Our approach is similar to the architecture adopted by Moonbeam, the precompile(s) are compliant with the ERC20 standard including event logging. Conversely, Acala uses the precompiles to solely interact with the runtime and uses pre-deployed Solidity contracts to handle everything else.
I have reused some of the utilities developed by Moonbeam here. See also their ERC20 precompile(s) for interacting with
pallet-assetshere. For reference, Acala has similar utility code here and their multicurrency precompile is here.TODO
PrecompileSetsAllowance,ApproveandTransferFromIt might be possible to use ethabi for encoding, worth investigating if we want to support additional precompiles.
Resources