Merge pull request #295 from mikehale/fix-rollbar-scope-extraction

Fix rollbar scope extraction
interagent · Jan 6, 2017 · fa9296a · fa9296a
2 parents ced8bf0 + 957fe6d
commit fa9296a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/lib/pliny/error_reporters/rollbar.rb b/lib/pliny/error_reporters/rollbar.rb
@@ -19,7 +19,7 @@ def notify(exception, context:, rack_env:)
 
       def fetch_scope(context:, rack_env:)
         scope = {}
-        if rack_env.respond_to?(:body)
+        unless rack_env.empty?
           scope[:request] = proc { extract_request_data_from_rack(rack_env) }
         end
         scope

diff --git a/spec/error_reporters/rollbar_spec.rb b/spec/error_reporters/rollbar_spec.rb
@@ -8,7 +8,7 @@
   describe "#notify" do
     let(:exception) { StandardError.new("Something went wrong") }
     let(:context)   { {} }
-    let(:rack_env)  { double(:rack_env, body: StringIO.new) }
+    let(:rack_env)  { { "rack.input" => StringIO.new } }
 
     subject(:notify) do
       reporter.notify(exception, context: context, rack_env: rack_env)
@@ -41,6 +41,10 @@
     context "given an empty rack_env" do
       let(:rack_env) { {} }
 
+      it "expects rack_env to be a hash" do
+        assert_kind_of(Hash, rack_env)
+      end
+
       it "reports to Rollbar with an empty scope" do
         notify
         expect(Rollbar).to have_received(:scoped).once.with({})