Update building docs #291
Merged
Update building docs #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
matbun
reviewed
Jan 16, 2025
matbun
reviewed
Jan 16, 2025
matbun
approved these changes
Jan 16, 2025
annaelisalappe
pushed a commit
that referenced
this pull request
Jan 22, 2025
* add examples of scalability plots from virgo * add scalability plots for virgo and eurac to docs * small virgo bugfix * fix warnings and add doc building action * suppress myst.header warning * fix undeline length * remove some redundant files * add back legacy scaling test report * remove prov4ml from tests (hopefully) * install prov4ml before testing * add new virgo plots and fix epoch_time_tracker bug * remove linux extra * fix ci build files * update docs readme with new changes and explanation for recurse submodules * update acronyms and line lengths in explain ddp * update batch_size in virgo and add explanation * fix linter errors in readme * fix linter errors in readme * fix errors in PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR contains three main changes:
Additionally, this solves a bug in the Virgo use case where the config was always overridden to be empty.
Related Issues: #290