Authz headers handled and set as attributes for traces #350
Conversation
…et as attributes of a span
pkg/interlink/config.go
Outdated
| @@ -113,25 +109,24 @@ func SetupTelemetry(ctx context.Context) (*sdktrace.TracerProvider, error) { | |||
| Certificates: []tls.Certificate{cert}, | |||
| RootCAs: certPool, | |||
| MinVersion: tls.VersionTLS12, | |||
| InsecureSkipVerify: false, | |||
| InsecureSkipVerify: true, // #nosec | |||
There was a problem hiding this comment.
why exactly? @Bianco95 :)
There was a problem hiding this comment.
If the CA used for the mTLS mechanism is not verified by a trusted authority, an error occurred when a trace is sent to the Tempo endpoint, specifically
2025/01/08 12:39:19 traces export: context deadline exceeded: rpc error: code = Unavailable desc = connection error: desc = "transport: authentication handshake failed: tls: failed to verify certificate: x509: certificate signed by unknown authority
There was a problem hiding this comment.
alright, only if you open an issue where we track that this value should be passed as a configuration parameter :) it can go for a later time, but we need to keep track
There was a problem hiding this comment.
Since this relates to telemetry configuration, I propose adding an environment variable, similar to how other telemetry parameters are handled. By default, insecureSkipVerify will be set to false, but users will have the option to override this and set it to true if needed.
…default, it is set to false
|
@Bianco95 can you document this env variable in the documenation of the monitoring as well? |
…INSECURE_SKIP_VERIFY)
|
Monitoring documentation has been properly updated |
|
Although, the integration test seems loke not working... need to check it carefully |
The SetupTelemetry function has been updated to dynamically create a service with a unique name depending on whether it is invoked by the VK or the InterLink API.
Additionally, information extracted from the AUTHZ headers is now included as attributes of the span associated with different HTTP calls.