This repository has been archived by the owner on Jul 18, 2024. It is now read-only.
Remove extra Transpose layers from the generated graph #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Rjasuja could you please rebase the PR. It has "001-Add-Float16-support-for-Resize-Bilinear-and-Resize-N.patch" patch. I think your changes will fail to reshape the tensor when model has multiple convolution nodes. (I could be wrong, i am unable to apply your patch and verify the changes) |
Tranpose layers are added to every operator's input and output if layout is NHWC Instead it should be added only at the beginning and end of the graph Signed-off-by: Ritul Jasuja <[email protected]>
Rjasuja
force-pushed
the
Optimize_transpose
branch
from
8e95fad
to
a981368
Compare
anikulk
reviewed
Mar 8, 2022
| if (!useNchw) { // No conversion needed if useNchw set | ||
| inputNode = transpose(NHWC_NCHW, inputNode); | ||
| transposed_nchw = true; | ||
| } |
There was a problem hiding this comment.
Can this code be shared by multiple operations? It seems like its needed in all operations, maybe we can have a function in the parent class?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tranpose layers are added to every operator's input and output if layout
is NHWC
Instead it should be added only at the beginning and end of the graph
Signed-off-by: Ritul Jasuja [email protected]