-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL][E2E] Re-enable interop_all_backends.cpp
test
#15767
Conversation
REQUIRES:
lit line
// REQUIRES: CUDA || HIP | ||
// RUN: %{build} %if hip %{ -DSYCL_EXT_ONEAPI_BACKEND_HIP %} %else %{ %if cuda %{ -DSYCL_EXT_ONEAPI_BACKEND_CUDA_EXPERIMENTAL %} %else %{ %if level_zero %{ -DSYCL_EXT_ONEAPI_BACKEND_L0 %} %} %} -o %t.out | ||
// REQUIRES: cuda || hip | ||
// RUN: %{build} %if any-device-is-hip %{ -DSYCL_EXT_ONEAPI_BACKEND_HIP %} %else %{ %if any-device-is-cuda %{ -DSYCL_EXT_ONEAPI_BACKEND_CUDA_EXPERIMENTAL %} %else %{ %if any-device-is-level_zero %{ -DSYCL_EXT_ONEAPI_BACKEND_L0 %} %} %} -o %t.out |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This way we will build an executable only for hip, or only for cuda, or only for l0.
Probably this line should be split into three lines with different executable names.
REQUIRES:
lit lineBasic/interop/interop_all_backends.cpp
test
Basic/interop/interop_all_backends.cpp
testinterop_all_backends.cpp
test
@ayylol Test is failing on HIP in postcommit unfortunately. Think you can fix it quickly? If not let's revert for now https://github.com/intel/llvm/actions/runs/11523103039/job/32080880588
|
The capitalization of cuda and hip in
Basic/interop/interop_all_backends.cpp
makes the test always unsupported. This patch removes the requires line, and refactors how the test is built so that we build an executable for each backend.