Improve compile command handling #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Pennycook <[email protected]>
- Test that strings are handled correctly. - Test that Paths are handled correctly. - Test for TypeError if argument is not a string or Path. Signed-off-by: John Pennycook <[email protected]>
Represents a single compile command from a compilation database. Signed-off-by: John Pennycook <[email protected]>
More refactoring is possible here, but deferred until 2.0.0. Signed-off-by: John Pennycook <[email protected]>
- Test that command and arguments fields are handled correctly. - Test that we can identify which commands we can/should emulate. Signed-off-by: John Pennycook <[email protected]>
laserkelvin
requested changes
Mar 18, 2024
Signed-off-by: John Pennycook <[email protected]>
Signed-off-by: John Pennycook <[email protected]>
laserkelvin
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
CompileCommandclass introduced here is intended to be part of a later refactoring. Things likeextract_definesand all the path handling inload_databaseshould eventually be folded into this class, but that can be deferred until 2.0.0.Related issues
Fixes #81.
Proposed changes
CompileCommandclass to represent a single entry in a compilation database.is_source_filefunction to check if a filename/path represents a source file CBI can understand.