Add TOML files required by tests from #56 #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Pennycook <[email protected]>
|
Closed and reopened to trigger the new CI. |
|
@laserkelvin - The CI correctly picked up the tests (thanks!) so I think this is ready for review now. |
Huzzah! Output is a bit spartan though... |
laserkelvin
approved these changes
Feb 26, 2024
That's true. We could add I think it's probably okay as it is. I don't expect we'll check the logs unless we have a failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
We didn't catch this because the unit tests aren't being run as part of the CI (see #47), and the missing files were present on my test machine.
Proposed changes