Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore missing {} to report outputs #57

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

Pennycook
Copy link
Contributor

Previous versions of CBI used {} to denote sets, for example:

  • {} for the empty set (unused code)
  • {CPU, GPU} for the set containing both CPU and GPU

When we upgraded to f-strings these braces were accidentally removed.

Related issues

N/A

Proposed changes

  • Surround set names with "{}" in report output.

Previous versions of CBI used {} to denote sets, for example:
- {} for the empty set (unused code)
- {CPU, GPU} for the set containing both CPU and GPU

When we upgraded to f-strings these braces were accidentally removed.

Signed-off-by: John Pennycook <[email protected]>
@Pennycook Pennycook added the bug Something isn't working label Feb 21, 2024
@Pennycook Pennycook added this to the 1.2.0 milestone Feb 21, 2024
@Pennycook Pennycook merged commit 5bf1d72 into intel:main Feb 23, 2024
1 check passed
@Pennycook Pennycook deleted the fix-set-notation branch February 23, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants