Add a new thread pool that switches between single- and multi- threaded execution #73
Conversation
| ///// - If `n == 1`, the task will be executed on the main thread without any locking mechanism. | ||
| ///// - For `n > 1`, the tasks will be delegated to the internal `NativeThreadPool` for parallel execution. | ||
| ///// | ||
| class SwitchNativeThreadPool { |
There was a problem hiding this comment.
According to the NativeThreadPoolBase ::parallel_for() implementation, a task is executed in the current thread in case of n == 1.
Why we cannot just fix existing code rather than making one more class?
There was a problem hiding this comment.
The default NativeThreadPool is designed to be thread-safe. We want to ensure that no external threads call parallel_for in parallel, even with n==1. That is, the lock in NativeThreadPool will be always at the beginning of parallel_for.
It would be better to have a separate implementation that focuses on this dynamic switching capability.
There was a problem hiding this comment.
Ok, thanks. Looking to NativeThreadPool::size() code I did not realize that NativeThreadPool is thread-safe.
A thread pool that dynamically switches between single-threaded and multi-threaded execution.
n == 1, the task will be executed on the main thread without any locking mechanism that exists inNativeThreadPool.n > 1, the tasks will be delegated to the internalNativeThreadPoolfor parallel execution.