Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid KeyError when attempting to access "properties" key #55

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Avoid KeyError when attempting to access "properties" key #55

wants to merge 1 commit into from

Conversation

larsks
Copy link

@larsks larsks commented Oct 22, 2021

Closes #54

@spiarh
Copy link

spiarh commented Nov 12, 2021

hi @garethr , any chance to see this merged ? This fixed the issue we hit running this script against the openapi resources from OpenShift 4.8. This allowed the script to generate the shared definitions.

Thanks @larsks and @garethr

@naved001 naved001 mentioned this pull request Nov 15, 2021
Closed
@ReDestroyDeR
Copy link

Hello @garethr, up on this PR. Issue #54 got a response from me and @paulcwarren and this commit is fixing it. When it's getting merged?

Thanks.

@bilbof
Copy link

bilbof commented Apr 9, 2022

I hit this issue with OpenShift 4.8 - can confirm the fix in the commit resolves it, thanks @larsks 👍

@larsks
Copy link
Author

larsks commented Mar 30, 2023

I'm collecting fixes in https://github.com/larsks/openapi2jsonschema. I've merged this patch into that repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"KeyError: properties" when parsing OpenAPI spec from Kubernetes
4 participants
@larsks @spiarh @ReDestroyDeR @bilbof