Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Import Sorting #638

Closed
wants to merge 3 commits into from
Closed

Conversation

max-muoto
Copy link
Contributor

@max-muoto max-muoto commented May 1, 2024

Enable import sorting through the isort rule-set: https://docs.astral.sh/ruff/rules/#isort-i

This is pretty standard for most Python projects, and should help promote general consistency when new imports are added.


🚀 This description was created by Ellipsis for commit fe52be0

Summary:

Enabled isort import sorting to enhance code readability and maintain consistency across Python files.

Key points:

  • Introduced isort for import sorting across various Python files.
  • Updated .ruff.toml to include isort checks.
  • Organized imports in multiple example scripts to adhere to standard Python style.

Generated with ❤️ by ellipsis.dev

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me!

  • Reviewed the entire pull request up to fe52be0
  • Looked at 2642 lines of code in 136 files
  • Took 1 minute and 2 seconds to review
More info
  • Skipped 0 files when reviewing.
  • Skipped posting 1 additional comments because they didn't meet confidence threshold of 85%.
1. .ruff.toml:31:
  • Assessed confidence : 0%
  • Comment:
    The changes correctly implement the isort rule for sorting imports, improving the consistency and readability of import statements across the project.
  • Reasoning:
    The PR introduces the isort rule for sorting imports in Python files. The changes in the PR are consistent with this rule, reordering imports alphabetically and grouping them appropriately. The PR description and the changes made align well, ensuring that imports are organized according to the standard Python style, which improves readability and maintenance of the code. No issues or further changes are necessary as the PR achieves its intended purpose effectively.

Workflow ID: wflow_1RT5vFfbxNhBb3Qe


You can customize Ellipsis with review rules, user-specific overrides, quiet mode, and more. See docs.

@jxnl jxnl closed this May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants