Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Include types to instructor.patch #422

Merged
merged 9 commits into from
Feb 14, 2024

Conversation

savarin
Copy link
Contributor

@savarin savarin commented Feb 9, 2024

This PR adds types to the following files, as per #390.

instructor/patch.py
tests/test_patch.py

Ellipsis 🚀 This PR description was created by Ellipsis for commit 26a57a8.

Summary:

This PR adds type annotations to instructor/patch.py and tests/test_patch.py, and includes these files in the MyPy check in .github/workflows/mypy.yml.

Key points:

  • Added type annotations to instructor/patch.py and tests/test_patch.py.
  • Updated .github/workflows/mypy.yml to include these files in MyPy check.
  • Made minor code adjustments in instructor/patch.py for type correctness.

Generated with ❤️ by ellipsis.dev

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!


Something look wrong? You can customize Ellipsis by editing the ellipsis.yaml for this repository.

Generated with ❤️ by ellipsis.dev

@savarin
Copy link
Contributor Author

savarin commented Feb 9, 2024

@jxnl FYI I got mypy to pass but had to remove generics.

@jxnl jxnl requested a review from lukevs February 9, 2024 15:39
@jxnl
Copy link
Collaborator

jxnl commented Feb 9, 2024

@lukevs how much will this fuck up the client pr?

@savarin
Copy link
Contributor Author

savarin commented Feb 12, 2024

@lukevs how much will this fuck up the client pr?

@lukevs Let me know what works best here. Happy to merge this one first and I'll help update your PR, or merge your PR first and I'll refresh this one. Thanks!

@lukevs
Copy link
Collaborator

lukevs commented Feb 12, 2024

Taking a look now

@lukevs
Copy link
Collaborator

lukevs commented Feb 12, 2024

These are fine for now. I'm close on types for the clients themselves which will change some of this logic, so I'm not attached to what's currently in main wrt the TypeVar / Params

@savarin
Copy link
Contributor Author

savarin commented Feb 12, 2024

These are fine for now. I'm close on types for the clients themselves which will change some of this logic, so I'm not attached to what's currently in main wrt the TypeVar / Params

@lukevs Sounds good, let me if I can help!

@savarin
Copy link
Contributor Author

savarin commented Feb 14, 2024

These are fine for now. I'm close on types for the clients themselves which will change some of this logic, so I'm not attached to what's currently in main wrt the TypeVar / Params

@jxnl Let me know if you have any more thoughts - thanks!

@jxnl jxnl merged commit f0d7889 into instructor-ai:main Feb 14, 2024
7 of 8 checks passed
jxnl added a commit that referenced this pull request Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants