-
-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Include types to instructor.patch #422
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Something look wrong? You can customize Ellipsis by editing the ellipsis.yaml for this repository.
Generated with ❤️ by ellipsis.dev
@jxnl FYI I got mypy to pass but had to remove generics. |
@lukevs how much will this fuck up the client pr? |
Taking a look now |
These are fine for now. I'm close on types for the clients themselves which will change some of this logic, so I'm not attached to what's currently in main wrt the TypeVar / Params |
cfc8db6
to
9cfd5eb
Compare
@lukevs Sounds good, let me if I can help! |
9cfd5eb
to
edf0465
Compare
edf0465
to
c89b67c
Compare
@jxnl Let me know if you have any more thoughts - thanks! |
This PR adds types to the following files, as per #390.
Summary:
This PR adds type annotations to
instructor/patch.py
andtests/test_patch.py
, and includes these files in the MyPy check in.github/workflows/mypy.yml
.Key points:
instructor/patch.py
andtests/test_patch.py
..github/workflows/mypy.yml
to include these files in MyPy check.instructor/patch.py
for type correctness.Generated with ❤️ by ellipsis.dev