Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT MERGE] remove generics and introduce types #421

Closed
wants to merge 1 commit into from
Closed

[DO NOT MERGE] remove generics and introduce types #421

wants to merge 1 commit into from

Conversation

savarin
Copy link
Contributor

@savarin savarin commented Feb 9, 2024

No description provided.

@savarin
Copy link
Contributor Author

savarin commented Feb 9, 2024

@jxnl I had trouble adding types to patch.py in its current state. I created this draft PR to illustrate how we're able to add types to patch.py but without using generics. Would you be open to removing the generics to get patch to pass mypy?

@savarin savarin closed this Feb 9, 2024
@jxnl
Copy link
Collaborator

jxnl commented Feb 9, 2024

thats fine since they are not working as expected anyways we'll have the new client in 1.0 but then we'll need the generics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@savarin @jxnl