Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Include types to instructor.dsl #419

Merged
merged 9 commits into from
Feb 9, 2024

Conversation

savarin
Copy link
Contributor

@savarin savarin commented Feb 9, 2024

This PR adds types to the following files, as per #390.

instructor/dsl/citation.py
instructor/dsl/iterable.py
instructor/dsl/maybe.py
instructor/dsl/parallel.py
instructor/dsl/partial.py
instructor/dsl/partialjson.py
instructor/dsl/validators.py

Ellipsis 🚀 This PR description was created by Ellipsis for commit 92aab60.

Summary:

This PR adds type annotations to several files in the instructor/dsl directory, improving code readability and type safety.

Key points:

  • Added type annotations to citation.py, iterable.py, maybe.py, parallel.py, partial.py, partialjson.py, and validators.py in the instructor/dsl directory.
  • Added type ignore comments where necessary.

Generated with ❤️ by ellipsis.dev

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!


Something look wrong? You can customize Ellipsis by editing the ellipsis.yaml for this repository.

Generated with ❤️ by ellipsis.dev

@jxnl jxnl merged commit 25f8214 into instructor-ai:main Feb 9, 2024
7 of 8 checks passed
@savarin savarin changed the title Include types to instructor.dsl chore: include types to instructor.dsl Feb 9, 2024
@savarin savarin changed the title chore: include types to instructor.dsl chore: Include types to instructor.dsl Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants