chore: Include types to instructor.distil and tests #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savarin
force-pushed
the
include-types-4
branch
from
b722827
to
2625661
Compare
savarin
changed the title
savarin
commented
Feb 5, 2024
| msg = f"Return type hint for {fn} must subclass `pydantic.BaseModel'" | ||
| assert is_return_type_base_model_or_instance(fn), msg | ||
| return_base_model = inspect.signature(fn).return_annotation | ||
|
|
||
| @functools.wraps(fn) | ||
| def _dispatch(*args, **kwargs): | ||
| def _dispatch(*args: Any, **kwargs: Any) -> Callable[..., T_Retval]: | ||
| name = name if name else fn.__name__ |
There was a problem hiding this comment.
Note change here to include name when null, since openai_kwargs requires non-null name. Alternative would be to set assert name is not None.
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
Looks good to me!
Something look wrong? You can customize Ellipsis by editing the ellipsis.yaml for this repository.
Generated with ❤️ by ellipsis.dev
savarin
force-pushed
the
include-types-4
branch
4 times, most recently
from
e154310
to
0328afd
Compare
jxnl
changed the title
savarin
force-pushed
the
include-types-4
branch
3 times, most recently
from
c56d1af
to
40078f6
Compare
jxnl
approved these changes
Feb 6, 2024
savarin
force-pushed
the
include-types-4
branch
2 times, most recently
from
5ba62e9
to
47c9fd7
Compare
savarin
force-pushed
the
include-types-4
branch
from
47c9fd7
to
91d8b4d
Compare
|
Don't worry about the Docs one. Is this good to merge? |
@jxnl OK will do, just puzzled why It's good to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds types to the following files, as per #390.
Summary:
This PR enhances type safety by adding type hints to the
instructor.distilmodule and its corresponding tests, and updates themypy.ymlworkflow to include these files.Key points:
instructor.distilmodule and its corresponding tests.mypy.ymlworkflow file to include type checking forinstructor/distil.pyandtests/test_distil.py.Generated with ❤️ by ellipsis.dev