Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(checkfield): update regexp of resource id #11

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Conversation

donch1989
Copy link
Member

Because

  • we are going to use snake_case style for resource id

This commit

  • update regexp of resource id

Copy link

linear bot commented Nov 22, 2023

INS-2673 update the regexp of resource ID and component ID

We'll use `^[a-z_][a-z_0-9]{0,31}$` for both resource ID and component ID

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (96477a4) 70.81% compared to head (25b3d52) 70.81%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #11   +/-   ##
=======================================
  Coverage   70.81%   70.81%           
=======================================
  Files           2        2           
  Lines         185      185           
=======================================
  Hits          131      131           
  Misses         48       48           
  Partials        6        6           
Flag Coverage Δ
unittests 70.81% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pinglin pinglin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pinglin pinglin merged commit 6928dd6 into main Nov 22, 2023
6 checks passed
@pinglin pinglin deleted the huitang/ins-2673 branch November 22, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: 👋 Done
Development

Successfully merging this pull request may close these issues.

2 participants