Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(metric): model trigger chart record api #245

Merged
merged 2 commits into from
Oct 31, 2024
Merged

feat(metric): model trigger chart record api #245

merged 2 commits into from
Oct 31, 2024

Conversation

joremysh
Copy link
Contributor

@joremysh joremysh commented Oct 29, 2024 •
edited
Loading

Because

  • dashboard needs API for model trigger count

This commit

  • add new metrics API

image

@linear Linear
Copy link

linear bot commented Oct 29, 2024

INS-6717 model trigger chart records api

@joremysh joremysh force-pushed the jeremy/ins-6717-model-trigger-chart-record-api branch from 7fa3523 to 29884c0 Compare October 29, 2024 09:12
@joremysh joremysh force-pushed the jeremy/ins-6717-model-trigger-chart-record-api branch from 29884c0 to b2b5aa5 Compare October 30, 2024 08:34
@joremysh joremysh marked this pull request as ready for review October 30, 2024 08:35
jvallesm
jvallesm reviewed Oct 30, 2024
View reviewed changes
pkg/repository/influx.go Outdated Show resolved Hide resolved
@joremysh joremysh force-pushed the jeremy/ins-6717-model-trigger-chart-record-api branch 2 times, most recently from fce05a9 to 4eb9fb3 Compare October 31, 2024 07:47
@joremysh joremysh force-pushed the jeremy/ins-6717-model-trigger-chart-record-api branch from 4eb9fb3 to 0b85b59 Compare October 31, 2024 07:50
@joremysh joremysh merged commit 89cce72 into main Oct 31, 2024
12 checks passed
@joremysh joremysh deleted the jeremy/ins-6717-model-trigger-chart-record-api branch October 31, 2024 08:03
@droplet-bot droplet-bot mentioned this pull request Oct 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvallesm jvallesm jvallesm approved these changes

@donch1989 donch1989 Awaiting requested review from donch1989 donch1989 is a code owner

@xiaofei-du xiaofei-du Awaiting requested review from xiaofei-du xiaofei-du is a code owner

@pinglin pinglin Awaiting requested review from pinglin pinglin is a code owner

Assignees
No one assigned
Labels
instill core
Projects
No open projects
🔮 Instill Core
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joremysh @jvallesm @droplet-bot