Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(metric): fix /tables pre-join action group key mismatch #121

Merged
merged 1 commit into from
Sep 13, 2023
Merged

chore(metric): fix /tables pre-join action group key mismatch #121

merged 1 commit into from
Sep 13, 2023

Conversation

heiruwu
Copy link
Member

@heiruwu heiruwu commented Sep 13, 2023

Because

  • mismatch group keys impact join action performance

This commit

  • fix /tables pre-join action group key mismatch

@linear
Copy link

linear bot commented Sep 13, 2023

INS-1867 /tables query performance

/tables query time is super long (>20s) on staging with dev-test-user-1

issue:

group key for renameTable greatly affect the performance of join

@heiruwu heiruwu merged commit 1dcd945 into main Sep 13, 2023
10 checks passed
@heiruwu heiruwu deleted the heiru/ins-1867-tables-query-performance branch September 13, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donch1989 donch1989 Awaiting requested review from donch1989 donch1989 is a code owner

@xiaofei-du xiaofei-du Awaiting requested review from xiaofei-du xiaofei-du is a code owner

@pinglin pinglin Awaiting requested review from pinglin pinglin is a code owner

Assignees
No one assigned
Labels
🗿 instill-base
Projects
No open projects
🔮 Instill Core
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heiruwu @droplet-bot