Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metric): fix pagination with multiple key sorting #106

Merged

Conversation

heiruwu
Copy link
Member

@heiruwu heiruwu commented Jul 24, 2023

Because

  • have duplicate records when sorting with multiple key with pagination

This commit

  • use trigger_time/execute_time as sorting key

Resolves INS-1388

@linear
Copy link

linear bot commented Jul 24, 2023

@linear
Copy link

linear bot commented Jul 24, 2023

INS-1388 fix legacy metric data mapping

old data format has

Tag:

  • pipeline_mode instead of trigger_mode
  • status as string type instead of enum

according to this thread

You can only update field values, to do so you must write a point with the same key (measurement, tags keys and value, time), once written it will override the previous data.

There is no way to update the existing datapoint's tag other then dropping it and write a new one.

@heiruwu heiruwu merged commit 020fc9e into main Jul 24, 2023
12 checks passed
@heiruwu heiruwu deleted the heiru/ins-1406-fix-duplication-datapoints-with-pagination branch July 24, 2023 17:39
heiruwu added a commit that referenced this pull request Jul 24, 2023
Because

- have duplicate records when sorting with multiple key with pagination

This commit

- use `trigger_time`/`execute_time` as sorting key

Resolves INS-1388
heiruwu pushed a commit that referenced this pull request Jul 24, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.3.12-alpha](v0.3.11-alpha...v0.3.12-alpha)
(2023-07-24)


### Bug Fixes

* **metric:** fix pagination with multiple key sorting
([#106](#106))
([aed156f](aed156f))


### Miscellaneous Chores

* **release:** release v0.3.12-alpha
([8315a0b](8315a0b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant