ci(Makefile): fix dind image missing bug #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinglin
requested review from
donch1989,
heiruwu and
Sarthak-instill
as code owners
pinglin
force-pushed
the
pinglin/ci-fix-makefile
branch
from
90be464
to
04b7862
Compare
donch1989
pushed a commit
that referenced
this pull request
Oct 27, 2023
Because - when `instill/vdp-compore:release` image is not present in the local Docker Engine (i.e., launch from scratch), the launch of `core` will fail when `make all` (without `BUILD=true`) This commit - fix the logic by specifically using release version for the tag of `insitll/vdp-compose` and detecting whether the image is present or not to build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
instill/vdp-compore:releaseimage is not present in the local Docker Engine (i.e., launch from scratch), the launch ofcorewill fail whenmake all(withoutBUILD=true)This commit
insitll/vdp-composeand detecting whether the image is present or not to build.