Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(env,makefile): add system config for persisten user_id #340

Merged
merged 1 commit into from
Aug 15, 2023
Merged

chore(env,makefile): add system config for persisten user_id #340

merged 1 commit into from
Aug 15, 2023

Conversation

heiruwu
Copy link
Member

@heiruwu heiruwu commented Aug 14, 2023

Because

  • support persistent user uuid for docker compose launch

This commit

  • add user_uuid file in config folder
  • pass through user_uuid as env variable for base mgmt-backend-init pod

@linear
Copy link

linear bot commented Aug 14, 2023

INS-1525 adopt default user uid in `vdp`

donch1989
donch1989 approved these changes Aug 15, 2023
View reviewed changes
Copy link
Member

@donch1989 donch1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@heiruwu heiruwu merged commit 8ae59b2 into main Aug 15, 2023
8 checks passed
@heiruwu heiruwu deleted the heiru/ins-1525-adopt-default-user-uid-in-vdp branch August 15, 2023 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donch1989 donch1989 donch1989 approved these changes

@praharshjain praharshjain Awaiting requested review from praharshjain

@Sarthak-instill Sarthak-instill Awaiting requested review from Sarthak-instill Sarthak-instill is a code owner

Assignees
No one assigned
Labels
None yet
Projects
No open projects
🔮 Instill Core
Status: 👋 Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heiruwu @donch1989