Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(component): modify schema for task chat #1102

Closed
wants to merge 4 commits into from
Closed

Conversation

chuang8511
Copy link
Member

@chuang8511 chuang8511 commented Sep 16, 2024

Because

  • There is missing filed in the schema

This commit

  • modify schema to init the vdp for task chat

p.s. There are lots of difference because we lint json layout. Mainly, we only add the title and order fields in the params.

@chuang8511 chuang8511 changed the title fix(component): modify schema fix(component): modify schema for task chat Sep 17, 2024
@chuang8511 chuang8511 marked this pull request as ready for review September 17, 2024 17:08
@chuang8511 chuang8511 marked this pull request as draft September 17, 2024 17:55
@chuang8511 chuang8511 marked this pull request as ready for review September 18, 2024 14:21
@heiruwu
Copy link
Member

heiruwu commented Sep 25, 2024

hi @chuang8511 it seems like we are using different level of indents for formatting json in our IDE, maybe we should agree on whether to use 2 or 4?

@chuang8511
Copy link
Member Author

@heiruwu Ah, okok.
Now, component repo is using 2. How about we use 2?

@chuang8511
Copy link
Member Author

I will redo it to align the universal ai component

@chuang8511 chuang8511 closed this Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: 🚧 Planned
Development

Successfully merging this pull request may close these issues.

3 participants