Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R225] Add description/example for eventTypeFilters param #41

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

b3nk4n
Copy link
Contributor

@b3nk4n b3nk4n commented Apr 26, 2022

What?

Add OpenAPI description and usage example for new query param added here:
https://github.ibm.com/instana/backend/pull/14882

@b3nk4n b3nk4n added enhancement New feature or request pending-next-release labels Apr 26, 2022
@b3nk4n b3nk4n requested a review from a team April 26, 2022 13:00
@@ -8,6 +8,8 @@ This endpoint retrieves all available events for the requested timeframe.
- **excludeTriggeredBefore:** Whether to exclude events that have been triggered before the requested timeframe in order to enable searching for events that have started within the given timeframe, excluding events that are previously active already. This is useful for 3rd party integrations that fetch events from Instana with a scheduled batch job in a fixed interval using tumbling windows, when you only care about new events.
This option is more restrictive than `filterEventUpdates` and does not inform about event state updates that got `CLOSED` in the timeframe of the query if not also the start time of the event is within that query timeframe.
- **filterEventUpdates:** Filters results to event updates only. This means that an event is only included when its event state changed in the given query timeframe. This is useful for 3rd party integrations that fetch events from Instana with a scheduled batch job in a fixed interval using a tumbling windows, when you care about event state updates.
- **filterEventUpdates:** Filters results to event updates only. This means that an event is only included when its event state changed in the given query timeframe. This is useful for 3rd party integrations that fetch events from Instana with a scheduled batch job in a fixed interval using a tumbling windows, when you care about event state updates.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably duplicated by mistake

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes, indeed 🐒

spec/descriptions/getEvents.md Outdated Show resolved Hide resolved
@maratynsky maratynsky self-requested a review April 26, 2022 14:48
Copy link
Member

@maratynsky maratynsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants