-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Runner Options for New Docker Transport #236
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Jeffrey Coe <[email protected]>
5263187
to
3781be5
Compare
Signed-off-by: Jeffrey Coe <[email protected]>
Was there intention to add tests for this change? |
Hi @miah - I have tests ready to go, but I have to add a dependency to a specific version of the kitchen-docker gem to the Gemfile. Unfortunately, a new version of the kitchen-docker gem hasn't been released yet with the latest code changes which includes the new docker transport. I'll commit the tests when the gem is released (which should happen soon). |
Will put this on our list to review, as https://rubygems.org/gems/kitchen-docker/versions/2.10.0 was released |
@jeffreycoe can this PR be closed, given that the PR it was to support (test-kitchen/kitchen-docker#340) has already merged? |
f403aed
to
fcf24e4
Compare
@james-stocks This should be ready to merge now that 2.10.0 of the kitchen-docker gem was released with the new docker transport. I made the requested changes to use alias_method instead, and added an integration test with the latest commits. |
Description
Adds InSpec runner options for the Docker transport. This is to support the docker transport in this PR: test-kitchen/kitchen-docker#340
Issues Resolved
N/A
Check List