-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add function to create CF-compliant arrays/metadata for HDF5 stacks #1073
base: main
Are you sure you want to change the base?
Conversation
We want to distinguish from other ValueErrors
we only want to convert 1D date to time
It's currently failing on one of the integration tests in the
so it's likely one of the 1D or 0D datasets is tripping it up (but that should be caught separately in |
Thank you @scottstanie for this exciting PR!!! I am trying to review this PR, but it does not seem easy to see what data and metadata have been added in the new format. Here are two questions for you:
For the intra-day stacks, @taliboliver uses the I am not familiar enough with the new changes in this PR yet to help the choice here. Having the above two questions answered would help. |
Description of proposed changes
Start of the implementation described here: #1016 to make mintpy HDF5 stacks readable by gdal/xarray/qgis.
I'll need to think of a way we can smoothly incorporate this into the
prep_
scripts without interruption.As a side note:
For now I still have
time
as the possible attribute for the date/datetime stacks just because that's what the CF-conventions suggested. They also generally have dates/datetime, but usetime
as the standard variable name (even if you have daily granularity).Also, it currently has
units=f"days since {str(date_arr[0])}"
as the time units, but this can beseconds
for intra-day stacks (e.g. for @taliboliver 's deltaX data). But i don't know what modifications he made; i've only seen that there's adate
dataset usually.Reminders