Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cat-voices): campaign categories - discovery page #1667

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

LynxLynxx
Copy link
Contributor

Description

Campaign categories card in grid view but I'm thinking if wrap wouldn't be better?

Related Issue(s)

Closes #1549

Description of Changes

  • adding new card widget
  • adding new ViewModel
  • creating gridview for categories cards

Screenshots

image image

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@LynxLynxx LynxLynxx added review me PR is ready for review ux/ui UX/UI related issues labels Jan 24, 2025
@LynxLynxx LynxLynxx self-assigned this Jan 24, 2025
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 443/443}$ | ${\color{red}Fail: 0/443}$ |

Comment on lines +64 to +66
List.generate(
6,
(index) => CampaignCategoryCardViewModel.dummy(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
List.generate(
6,
(index) => CampaignCategoryCardViewModel.dummy(),
List.filled(
6,
CampaignCategoryCardViewModel.dummy(),


String get _availableFundsText {
// ignore: lines_longer_than_80_chars
return '${const Currency.ada().symbol} ${AmountFormatter.decimalFormat(availableFunds)}';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use CryptocurrencyFormatter?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review me PR is ready for review ux/ui UX/UI related issues
Projects
Status: New
Development

Successfully merging this pull request may close these issues.

Implement Campaign Categories
2 participants