Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat related video overlay) hide video information that contains Store ads in some cases #131

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

MondayNitro
Copy link

not very meaningful patch, but can hide Store ads that appear in some videos

Screenshot 2025-01-19 150732

@Francesco146
Copy link

Francesco146 commented Jan 19, 2025

related to this PR, a more dynamic way of dealing with these ads, is to use the custom litho filter:

offer_module

@MondayNitro
Copy link
Author

offer_module

not works on my device

@Francesco146
Copy link

then it was removed in the latest versions, all i can say is that it works up to version v19.16.39

@ILoveOpenSourceApplications

I just found out that fullscreen_overlay hides the store part but leaves out the outline for it there. Using ReVanced by the way.

01-19 22:10:30.625 31672 31672 D revanced: LithoFilterPatch: Searching ID: fullscreen_overlay.eml|496944a54432aa3f Path: fullscreen_overlay.eml|496944a54432aa3f|fullscreen_overlay_inner.eml|961931b64543ed2c|CellType| BufferStrings: button.eml|713fd10bcb423d23❙From1,428.07❙sans-serif-regular❙sans-serif-regular❙12 products❙sans-serif-regular❙Shelby's Canada store❙sans-serif-regular❙https://encrypted-tbn2.gstatic.com/shopping?

@Francesco146
Copy link

yes, offer_module does the same thing in older versions. we currently don't know how to hide the supplement part

@ILoveOpenSourceApplications

That's something I guess. At least the ad part will be gone.

@Francesco146
Copy link

yeah, even though it's not very polished, it might be worth adding a toggle for that filter as an experimental flag

@ILoveOpenSourceApplications

yeah, even though it's not very polished, it might be worth adding a toggle for that filter as an experimental flag

Nah, just add a limitation saying that the outline will remain. That should be enough.

@Francesco146
Copy link

just add a limitation saying that the outline will remain

that's what I meant

@MondayNitro
Copy link
Author

yeah, even though it's not very polished, it might be worth adding a toggle for that filter as an experimental flag

Nah, just add a limitation saying that the outline will remain. That should be enough.

can you also find custom filters for remaining items (title and channel)? i think something can be done about the outline

Screenshot_20-1-2025_12548_private-user-images githubusercontent com

@Francesco146
Copy link

Francesco146 commented Jan 19, 2025

going through my log i tested:

  • video_action_bar: removes all line with the buttons
  • video_metadata: removes all the buttons under the video

these are hard to test individually, but they removes the button to close the fullscreen video, and all the contents inside te dividers you sent. no luck on those dividers:

  • compact_channel_bar
  • compact_channel_bar_inner
  • compact_channel_bar_header
  • fullscreen_overlay
  • fullscreen_overlay_inner

maybe that component is created before going to fullscreen?

the last thing i noticed, it that the request for loading the content of that type of ad is coming from:
https://encrypted-tbn0.gstatic.com/shopping?q=tbn:<code>

last tested
  • video_metadata_inner
  • video_metadata_carousel
  • horizontal_shelf
  • info_card_teaser_overlay
  • cell_divider
  • player_overlay_video_heading
  • video_metadata_carousel_content
  • related_watch_next_end_screen
  • animated_subscribe_button
  • video_action_button_with_vm_input
  • video_action_button_pill
  • info_card_teaser_overlay
  • player_overlay_video_heading
  • compact_channel
  • quick_actions
  • video_action_bar
  • lock_mode_suggested_action
  • info_card_teaser_overlay.eml-js-b
  • player_overlay_video_heading.eml
  • shopping_fullscreen_overlay
  • id.shopping_fullscreen_overlay.view

@MondayNitro
Copy link
Author

none of these filters hide video title in related video overlay😥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants