Fix APIErrorCode class (did not work as expected) #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johndgiese
reviewed
Jul 16, 2024
There was a problem hiding this comment.
Hey @sHermanGriffiths can you have Bimba review this please? I left one comment
|
|
||
|
|
||
| def test_apierrorcode_contains(): | ||
| errors = [ |
There was a problem hiding this comment.
Very cool! Checkout pytest fixtures for another way to do this: https://docs.pytest.org/en/6.2.x/fixture.html#parametrizing-fixtures
There was a problem hiding this comment.
Yep yep! We use them in other tests in the notion-qms repo I think. If we expand this module I'll probably end up shifting to that method to avoid definition repetition.
bimbashrestha
approved these changes
Jul 18, 2024
sHermanGriffiths
force-pushed
the
shg/errcodefix
branch
from
96b5687
to
d3b4a19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
The previous edits didn't work as expected and raised an error
How Did You Test It
Write
test_apierrorcode_contains