Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add database handle for emoji icon #152

Merged
merged 1 commit into from
Sep 14, 2023
Merged

add database handle for emoji icon #152

merged 1 commit into from
Sep 14, 2023

Conversation

sHermanGriffiths
Copy link
Contributor

Describe Your Changes

Duplicate icon handling for pages to databases so they can handle icons as well.

How Did You Test It

I exported the database that was throwing this error and made sure that it exported correctly

@sHermanGriffiths sHermanGriffiths marked this pull request as ready for review September 14, 2023 23:27
yujanshrestha
yujanshrestha approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@yujanshrestha yujanshrestha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Note. I just did a cursory review. The changes appear low risk. I did not fully evaluate the implications of removing the Page.emoji property.

@sHermanGriffiths sHermanGriffiths merged commit 41b86ba into main Sep 14, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yujanshrestha yujanshrestha yujanshrestha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sHermanGriffiths @yujanshrestha