ignore casing of terms matched by the fuzzy_find_in jinja filter #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bimbashrestha
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
Modified the
re.finditrcall tore.IGNORECASEso that lower cased references to the key terms still get matchedHow Did You Test It
I exported SW-0010_MIC_Finder_SDDS_Rev_C from Specific-Dx and ensured that Software Item was included in the glossary, as it's referenced in the document, although in lowercase. I ran the debugger on my n2y code to see if the terms were coming through correctly and they were so that indicated to me that the matching system was filtering out the desired terms. I immediately knew it was the casing so I added the aforementioned flag and that fixed the issue