Add platform-specific socket setting functions #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit introduces two new files called `util_windows.go` and `util_unix.go` which contain specific socket options' settings for Windows and Unix. These functions replace the previous implementation in `util.go`, resulting in cleaner code and segregating functionalities based on the system platform.
The commit updates the Unix socket settings function from using the SO_REUSEADDR option to the SO_REUSEPORT option. This change is made in the `util_unix.go` file. SO_REUSEPORT is preferable as it permits multiple sockets to be bound to an identical socket address.
|
@ryanbekhen, thank you for the PR. Can you pull the latest to make sure the test gets passed? Can you also share what you want to develop with this SFU lib? Is there anything missing you would like to have in the lib? |
|
OK, I'll try tonight, and for now I'm still studying this library first, if there's anything that needs to be added, maybe I can let you know. |
|
@tyohan Maybe for now, in my opinion, it is for support for other operating systems too, so that if there are other developers who want to develop, they can use the operating system they have. |
|
@tyohan can you test again |
tyohan
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit introduces two new files called
util_windows.goandutil_unix.gowhich contain specific socket options' settings for Windows and Unix. These functions replace the previous implementation inutil.go, resulting in cleaner code and segregating functionalities based on the system platform.