feat: add bitrates config for webcam and screenshare and adjust the d…

…efault sendEncoding to VP9 bitrate (#104) * add bitrates config based on video type --------- Co-authored-by: Yohan Totting <[email protected]> Co-authored-by: Faiq Naufal <[email protected]>
inlivedev · Apr 3, 2024 · dcddf8e · dcddf8e
1 parent b12bce5
commit dcddf8e
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 13 deletions.
diff --git a/packages/room/config/config.js b/packages/room/config/config.js
@@ -26,13 +26,23 @@ export const media = {
     simulcast: false,
     svc: true,
     scalabilityMode: 'L3T1',
+    bitrates: {
+      high: 700 * 1000,
+      mid: 300 * 1000,
+      low: 100 * 1000,
+    },
   },
   screen: {
     maxFramerate: 30,
     videoCodecs: ['video/VP8', 'video/H264', 'video/VP9'],
     simulcast: false,
     svc: true,
     scalabilityMode: 'L1T2',
+    bitrates: {
+      high: 1200 * 1000,
+      mid: 500 * 1000,
+      low: 150 * 1000,
+    },
   },
   microphone: {
     audioCodecs: ['audio/red', 'audio/opus'],

diff --git a/packages/room/peer/peer.js b/packages/room/peer/peer.js
@@ -24,12 +24,6 @@ export const createPeer = ({ api, createStream, event, streams, config }) => {
     _bwController
     /** @type {VideoObserver | null} */
     _videoObserver
-    /** @type {number} */
-    _highBitrate
-    /** @type {number} */
-    _midBitrate
-    /** @type {number} */
-    _lowBitrate
     /** @type {Array<HTMLVideoElement>} */
     _pendingObservedVideo
     /** @type {Array<RTCIceCandidate>} */
@@ -50,9 +44,6 @@ export const createPeer = ({ api, createStream, event, streams, config }) => {
       })
 
       this._videoObserver = null
-      this._highBitrate = 1200 * 1000
-      this._midBitrate = 500 * 1000
-      this._lowBitrate = 150 * 1000
       this._pendingObservedVideo = []
       this._pendingIceCandidates = []
       /**
@@ -557,6 +548,12 @@ export const createPeer = ({ api, createStream, event, streams, config }) => {
         const transceiverInit = {
           direction: 'sendonly',
           streams: [stream.mediaStream],
+          sendEncodings: [
+            {
+              maxBitrate: config.media[type].bitrates.high,
+              maxFramerate: config.media[type].maxFramerate,
+            },
+          ],
         }
 
         const svcEnabled = config.media[type].svc && browserName !== FIREFOX
@@ -569,21 +566,21 @@ export const createPeer = ({ api, createStream, event, streams, config }) => {
             {
               rid: 'high',
               maxFramerate: config.media[type].maxFramerate,
-              maxBitrate: this._highBitrate,
+              maxBitrate: config.media[type].bitrates.high,
             },
             {
               rid: 'mid',
               // eslint-disable-next-line unicorn/no-zero-fractions
               scaleResolutionDownBy: 2.0,
               maxFramerate: config.media[type].maxFramerate,
-              maxBitrate: this._midBitrate,
+              maxBitrate: config.media[type].bitrates.mid,
             },
             {
               rid: 'low',
               // eslint-disable-next-line unicorn/no-zero-fractions
               scaleResolutionDownBy: 4.0,
               maxFramerate: config.media[type].maxFramerate,
-              maxBitrate: this._lowBitrate,
+              maxBitrate: config.media[type].bitrates.low,
             },
           ]
 
@@ -606,7 +603,7 @@ export const createPeer = ({ api, createStream, event, streams, config }) => {
             transceiverInit.sendEncodings = sendEncodings
           } else {
             const sendEncodings = {
-              maxBitrate: this._highBitrate,
+              maxBitrate: config.media[type].bitrates.high,
               scalabilityMode: config.media[type].scalabilityMode,
               maxFramerate: config.media[type].maxFramerate,
             }