chore: add yomitestnet #205
Conversation
|
Warning Rate limit exceeded@chlwys has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 39 minutes and 1 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughA new testnet configuration for the Yominet blockchain has been established, introducing two critical JSON files: an asset list and a chain configuration. The Changes
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
fix: move initiation-2 channels
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
testnets/initia/chain.json (1)
239-240: Minor: Fix JSON formatting inconsistenciesThere are some minor formatting inconsistencies in the new entries:
- Inconsistent spacing after colons in
port_idfields- Extra space after "ics721-1" in line 247
- "port_id":"transfer", + "port_id": "transfer", - "port_id":"nft-transfer", + "port_id": "nft-transfer", - "version": "ics721-1" + "version": "ics721-1"Also applies to: 244-247
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
testnets/initia/chain.json(1 hunks)testnets/yominet/assetlist.json(1 hunks)testnets/yominet/chain.json(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- testnets/yominet/chain.json
🔇 Additional comments (7)
testnets/yominet/assetlist.json (4)
6-12: Update description to match the ecosystem name.The description mentions "Kamigotchi" while the chain name is "yominet". This inconsistency was previously noted in past reviews.
- "description": "The Kamigotchi world currency", + "description": "The Yominet world currency",
13-15: Verify ERC20 contract deployment.Please ensure that the ERC20 contract is deployed and verified at address
0x9D9c32921575Fd98e67E27C0189ED4b750Cb17C5on the Yominet testnet.
16-19: LGTM! Asset properties are consistent.The display, name, and symbol are consistently set. Empty CoinGecko ID is acceptable for testnet.
1-3: Verify JSON schema validation.Let's ensure the file exists and validate the JSON against the schema.
✅ Verification successful
Schema validation successful
The assetlist.json file correctly follows the schema requirements, including proper schema reference, required fields, and valid asset configuration.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check if schema file exists and validate JSON if [ -f "assetlist.schema.json" ]; then echo "Schema file exists" else echo "Schema file not found" fiLength of output: 81
Script:
#!/bin/bash # Check schema content cat assetlist.schema.jsonLength of output: 13723
Script:
#!/bin/bash # Check complete content of yominet's assetlist.json cat testnets/yominet/assetlist.jsonLength of output: 1141
testnets/initia/chain.json (3)
238-242: LGTM: IBC transfer channel configurationThe transfer channel configuration for preyominet-1 follows the standard IBC protocol specification with the correct version string (ics20-1).
243-247: LGTM: IBC NFT transfer channel configurationThe NFT transfer channel configuration for preyominet-1 follows the standard IBC protocol specification with the correct version string (ics721-1).
238-247: Verify IBC channel configurationLet's verify that these channel IDs are correctly configured and match the corresponding channels on the preyominet-1 chain.
✅ Verification successful
IBC channels are correctly configured ✅
The channel configuration between initia (initiation-2) and yominet (preyominet-1) is properly set up with matching transfer (ics20-1) and nft-transfer (ics721-1) channels on both ends.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for corresponding channel configurations in preyominet-1 chain # Search for matching channel configurations in other chain files echo "Searching for corresponding channel configurations in preyominet chain..." rg -l "preyominet-1" . | while read -r file; do if [[ "$file" != "testnets/initia/chain.json" ]]; then echo "Found reference in: $file" # Extract and display channel configurations jq -r '.metadata.ibc_channels[] | select(.chain_id=="initiation-2")' "$file" 2>/dev/null fi doneLength of output: 1055
Script:
#!/bin/bash # Description: Extract preyominet-1 channel configurations from yominet chain echo "Checking yominet chain configuration..." jq -r '.metadata.ibc_channels[] | select(.chain_id=="preyominet-1")' ./testnets/yominet/chain.json echo -e "\nChecking initia chain configuration..." jq -r '.metadata.ibc_channels[] | select(.chain_id=="preyominet-1")' ./testnets/initia/chain.jsonLength of output: 613
Script:
#!/bin/bash # Search for preyominet chain configuration echo "Searching for preyominet chain configuration file..." fd chain.json | while read -r file; do echo -e "\nChecking $file for preyominet configuration..." jq -r '.chain_id + " in " + input_filename' "$file" "$file" if jq -e '.chain_id == "preyominet-1"' "$file" >/dev/null; then echo "Found preyominet chain config. Checking IBC channels..." jq -r '.metadata.ibc_channels[] | select(.chain_id=="initiation-2")' "$file" fi doneLength of output: 4396
Script:
#!/bin/bash echo "Checking channels in yominet/chain.json connecting to initia..." jq -r '.metadata.ibc_channels[] | select(.chain_id=="initiation-2")' ./testnets/yominet/chain.json echo -e "\nChecking channels in initia/chain.json connecting to yominet..." jq -r '.metadata.ibc_channels[] | select(.chain_id=="preyominet-1")' ./testnets/initia/chain.jsonLength of output: 938
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
testnets/yominet/assetlist.json(1 hunks)
🔇 Additional comments (3)
testnets/yominet/assetlist.json (3)
6-12: Update description to use consistent naming.The description still references "Kamigotchi" while the chain name is "yominet".
- "description": "The Kamigotchi world currency", + "description": "The Yominet world currency",
20-29: Fix redundant URLs and verify image resources.
- The URLs in
imagesandlogo_URIsare identical, creating unnecessary redundancy- Verify that the image files exist with the correct case sensitivity
#!/bin/bash # Check if image files exist fd -t f "onyx\.(png|svg)$" testnets/yominet/images/ # Suggest removing redundancy cat << 'EOF' Consider using either `images` or `logo_URIs`, but not both with identical values. EOF
13-19: Verify ERC20 contract address.The contract address appears to be used consistently, but let's verify its validity and deployment.
✅ Verification successful
ERC20 contract address verified successfully
The contract address follows the correct format and is used consistently across testnet configurations and registry files.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check if the contract address follows ERC20 format if [[ "0x9D9c32921575Fd98e67E27C0189ED4b750Cb17C5" =~ ^0x[a-fA-F0-9]{40}$ ]]; then echo "Valid ERC20 address format" else echo "Invalid ERC20 address format" fi # Search for other occurrences of this contract rg -i "9D9c32921575Fd98e67E27C0189ED4b750Cb17C5"Length of output: 778
fix: add json rpc
Summary by CodeRabbit
New Features
Documentation