Bars as rects #222
Merged
Bars as rects #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pollen8
commented
Nov 17, 2023
•
pollen8
commented
- replace the Bars/bars helpers logic with code to render svg paths with arcs as rounded corners.
- Fixed Tornado charts rendering at width 0 which created interesting animations. Now animations won't start until the chart width and height are not 0
- Added some extra tests to capture the correct layout for the bars
iendjinn
reviewed
Nov 17, 2023
iendjinn
previously approved these changes
Nov 17, 2023
Co-authored-by: Ivan <[email protected]> Signed-off-by: Rob Clayburn <[email protected]>
iendjinn
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.