Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Update test api for 20160226 command set #61

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Thooms
Copy link
Contributor

@Thooms Thooms commented Mar 23, 2016

No description provided.

@Thooms
Copy link
Contributor Author

Thooms commented Mar 23, 2016

@k-bx @qrilka here is my first shot at rewriting a correct testsuite. I only wrote the tests for the strings, and I'd like to know if all seems correct before writing everything else!
The main goal of having separate tests for all the commands is to prepare the switch to handwritten commands. I'll certainly split the testsuite in separate files in this PR, too.

@Thooms Thooms changed the title Update test api for 20160226 command set [WIP] Update test api for 20160226 command set Mar 23, 2016
@qrilka
Copy link
Contributor

qrilka commented Mar 23, 2016

@Thooms have you seen build failures on Travis?
e.g. HSTRLEN missing? I don't quite understand how got get Redis version used in Travis but I guess we don't need to enable by default all of the tests and use commands existing from some particular version. Probably that one is from Ubuntu Trusty which seems to have 2.8.4

@qrilka
Copy link
Contributor

qrilka commented Mar 23, 2016

It looks that Precise is the default - https://docs.travis-ci.com/user/ci-environment/ so Redis there is even older than I thought.
So it looks like we need not to use standard Redis and use some fresh versions, like 2.8, 3.0 (currently stable) and 3.2 (as we have some commands for it already).
And the test suite should disable tests according to Redis version

@qrilka
Copy link
Contributor

qrilka commented Mar 23, 2016

and the tests themselves look good to me, thanks @Thooms

@qrilka qrilka mentioned this pull request Mar 23, 2016
@Thooms
Copy link
Contributor Author

Thooms commented Mar 24, 2016

Yes, I saw the Travis fails, I'll try to fix that, and I'll write the rest of the tests (that'll take some time, don't worry if you don't have update) :)

@qrilka
Copy link
Contributor

qrilka commented Mar 28, 2016

@Thooms could you rebase you branch on https://github.com/informatikr/hedis/tree/commands-20160226 ?
I almost have code to run tests according to Redis version but because of haddock codegen change in #62 merge could get not clean

@qrilka
Copy link
Contributor

qrilka commented Jun 2, 2016

hi @Thooms - do you still plan to continue this effort?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants