Update rustc option for instrument-coverage #1377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In nightly, the compiler flag graduated from -Z to -C (stable options).
Throw in -C link-dead-code into the compiler flags for the nightly-coverage CI job.
Remove imports that are reported as unused by the nightly compiler, override the lint for the vec macro import that is actually used.
5 tasks
Override the lint more selectively, specifically for this macro re-export.
Codecov Report
@@ Coverage Diff @@
## main #1377 +/- ##
=======================================
- Coverage 59.7% 59.0% -0.7%
=======================================
Files 275 275
Lines 27597 27930 +333
=======================================
+ Hits 16485 16491 +6
- Misses 11112 11439 +327
... and 4 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
romac
approved these changes
Nov 9, 2023
mzabaluev
added a commit
that referenced
this pull request
Feb 21, 2024
* chore: update rustc flag for instrument-coverage In nightly, the compiler flag graduated from -Z to -C (stable options). * CI: link dead code for coverage Throw in -C link-dead-code into the compiler flags for the nightly-coverage CI job. * Fix prelude imports Remove imports that are reported as unused by the nightly compiler, override the lint for the vec macro import that is actually used. * Restore vec macro import in prelude Override the lint more selectively, specifically for this macro re-export.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the
nightly-coverageCI job by adjusting the flag for the nightlyrustc compiler.
Also throw in
-C link-dead-codeinto the compiler flags for thenightly-coverage CI job.