Fixes #1523 #1561
Merged
Fixes #1523 #1561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugarela
approved these changes
Dec 12, 2024
quint/test/runtime/compile.test.ts
Outdated
Comment on lines
901
to
903
| assertResultAsString('Set().setOfMaps(Set(3, 5)) == Set(Map())', 'true') | ||
| assertResultAsString('Set().setOfMaps(Set()) == Set(Map())', 'true') | ||
| assertResultAsString('Set(1, 2).setOfMaps(Set()) == Set()', 'true') |
There was a problem hiding this comment.
This makes it a bit easier to read and will also result in better error messages if it ever breaks (i.e. someone tries to remove one of the ifs you added). The way you wrote it will result in error messages like "expected true, got false" which is not as helpful as "expected Set(), got Set(Map())".
Suggested change
| assertResultAsString('Set().setOfMaps(Set(3, 5)) == Set(Map())', 'true') | |
| assertResultAsString('Set().setOfMaps(Set()) == Set(Map())', 'true') | |
| assertResultAsString('Set(1, 2).setOfMaps(Set()) == Set()', 'true') | |
| assertResultAsString('Set().setOfMaps(Set(3, 5))', 'Set(Map())') | |
| assertResultAsString('Set().setOfMaps(Set())', 'Set(Map())') | |
| assertResultAsString('Set(1, 2).setOfMaps(Set())', 'Set()') |
|
Thank you! For the "Fixes #1523", I think it needs to be on the description, not the title. I just edited your description to add it - see how "Fixes" gets a underscore and, if you hover over it, GitHub explains that this will close the appropriate issue. I'll go ahead and merge it. Thanks a lot for the contribution ✨ |
4 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empty domains and empty ranges in the setOfMaps operator now give Set(Map()) and Set() respectively, like TLC.
Fixes #1523