Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct flaky test (TestLauncher_PIDFile_Locked) #25490

Merged
merged 1 commit into from
Oct 24, 2024
Merged

fix: correct flaky test (TestLauncher_PIDFile_Locked) #25490

merged 1 commit into from
Oct 24, 2024

Conversation

gwossum
Copy link
Member

@gwossum gwossum commented Oct 24, 2024

Closes #25489

@gwossum gwossum marked this pull request as ready for review October 24, 2024 22:20
@gwossum gwossum self-assigned this Oct 24, 2024
@gwossum gwossum added kind/bug area/2.x OSS 2.0 related issues and PRs labels Oct 24, 2024
davidby-influx
davidby-influx approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@davidby-influx davidby-influx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gwossum gwossum merged commit 48f7600 into main-2.x Oct 24, 2024
25 checks passed
@gwossum gwossum deleted the gw/25489/no_atim_compare branch October 24, 2024 22:26
This was referenced Oct 29, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidby-influx davidby-influx davidby-influx approved these changes

Assignees

@gwossum gwossum

Labels
area/2.x OSS 2.0 related issues and PRs kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gwossum @davidby-influx