Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links #24577

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Fix broken links #24577

merged 2 commits into from
Jan 16, 2024

Conversation

martinfrancois
Copy link
Contributor

When creating an issue, I found that most of the links in the template, like to the CONTRIBUTING.md were broken and I found out that it was due to the renaming of the repository. I replaced the links so they are working again.

  • I've read the contributing section of the project README.
  • Signed CLA (if not already signed).

Copy link
Contributor

@mgattozzi mgattozzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @martinfrancois! Thanks for dropping a PR to fix up some broken links. I just wanted to give you some context as to why some of these were broken. It's not that the repo was renamed (this still hosts the 1.x and 2.x versions on separate branches here), but that the code for 3.0 was pushed from the influxdb_iox repo (which is private) to influxdb as a snapshot and a starting point for us to work on InfluxDB Edge which we've started work on recently. As such some of these links are actually referring to the correct thing, but in a different repo!

This will eventually be changed over time as we work on Edge, but for now it's pretty early days.

All this is to say that I think if we limit the changes to the .github folder and the CONTRIBUTING.md I can approve those changes and merge them in for you!

@martinfrancois
Copy link
Contributor Author

martinfrancois commented Jan 16, 2024

Hi @mgattozzi, you're welcome! Got it, it makes sense now. Thanks a lot for providing the context! I made the changes you requested, can you please have another look?

Copy link
Contributor

@mgattozzi mgattozzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @martinfrancois thanks for the quick turn around. I'm approving these changes so I can merge them in and thanks for contributing to InfluxDB and making the docs better 😄

@mgattozzi mgattozzi merged commit 58bec1d into influxdata:main Jan 16, 2024
11 of 12 checks passed
@martinfrancois
Copy link
Contributor Author

Hey @mgattozzi you're welcome, thanks as well for the quick reaction and for merging! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants