Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(contributing): update setup #24561

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

jdockerty
Copy link
Member

@jdockerty jdockerty commented Jan 9, 2024

Following the current guide led me to some errenous errors, largely because I followed the need for Go 1.15 🤦

Once I checked the go.mod file, I noticed the mention of Go1.15 was outdated. Using 1.20 fixed my issue and I've included a small setup change to help any other weary travellers avoid my mistake, by directly installing the correct version via gvm using the go.mod file as the source of truth.

  • I've read the contributing section of the project README.
  • Signed CLA (if not already signed).

@jdockerty jdockerty self-assigned this Jan 9, 2024
@jdockerty jdockerty marked this pull request as ready for review January 9, 2024 17:02
Copy link
Contributor

@davidby-influx davidby-influx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jdockerty jdockerty merged commit 7dec23b into master-1.x Jan 9, 2024
12 checks passed
@jdockerty jdockerty deleted the docs/getting-started-go-version branch January 9, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants