feat: expand test cases

influxdata · Jan 12, 2024 · e904943 · e904943
1 parent cf5717a
commit e904943
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/tsdb/series_cursor.go b/tsdb/series_cursor.go
@@ -114,7 +114,7 @@ func (cur *seriesCursor) Next() (*SeriesCursorRow, error) {
 
 		cur.row.Name, cur.row.Tags = ParseSeriesKey(cur.keys[cur.ofs])
 		if cur.row.Name == nil && cur.row.Tags == nil {
-			return nil, fmt.Errorf("series key was not valid: %s", cur.keys[cur.ofs])
+			return nil, fmt.Errorf("series key was not valid: %+v", cur.keys[cur.ofs])
 		}
 		cur.ofs++
 

diff --git a/tsdb/series_file_test.go b/tsdb/series_file_test.go
@@ -54,12 +54,18 @@ func TestParseSeriesKeyMeasurement(t *testing.T) {
 	tests := []struct {
 		name        string
 		measurement []byte
+		expected    []byte
 	}{
-		{name: "invalid measurement", measurement: []byte{}},
+		{name: "invalid measurement", measurement: tsdb.AppendSeriesKey(nil, []byte{}, nil), expected: nil},
+		{name: "valid measurement", measurement: tsdb.AppendSeriesKey(nil, []byte("cpu"), nil), expected: []byte("cpu")},
 	}
 
 	for _, tt := range tests {
-		tsdb.ParseSeriesKey(tt.measurement)
+		name, _ := tsdb.ParseSeriesKey(tt.measurement)
+		if res := bytes.Compare(name, tt.expected); res != 0 {
+			t.Fatalf("invalid series key parse: got %q, expected %q", name, tt.expected)
+		}
+
 	}
 
 }