-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: memory leaks #64
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bednar swift test doesn't pass on master branch, it waits for http://localhost:8086/ |
I don't know how to fix the last one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dankinsoid,
Thank you very much for your Pull Request. It appears that the final check is failing due to flakiness of the tests on the macOS platform. However, we're still able to merge your PR regardless, as from my point of view, it looks perfectly fine!
If you have any other contributions or suggestions, please don't hesitate to share them. We greatly appreciate your efforts.
Best Regards.
@bednar Hello! Do I need to do smth to merge the PR? I need it for my library |
Thanks again for your PR 👍. I will merge at Monday and after that we will release new version of the client. |
Hi @dankinsoid, I wanted to give you an update on the progress we're making with your Pull Request. I've prepared PR #66 to address some CI checks issues we've been facing. Once PR #66 is reviewed and merged, we will be able to proceed with merging your PR as well. As mentioned yesterday, we are on track to release the new version of the client, which will include your fix, by the end of this week. Thank you for your patience and your contributions. I'll keep you updated as we move forward. Best regards |
@bednar thank you! |
@dankinsoid, the PR has been merged. Thank you very much once again for your contribution! |
Closes #63
Closes #65
Proposed Changes
Checklist
swift test
completes successfully