Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compatible with latest dart version #151

Merged
merged 6 commits into from
Nov 20, 2024
Merged

fix: compatible with latest dart version #151

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ce796c6
chore: `intl` package is not required, the API doesn't require `_date…
bednar Nov 20, 2024
e1f11c4
fix: ubuntu image
bednar Nov 20, 2024
0b67728
chore: the pubspec.lock should not be in repo because it is determini…
bednar Nov 20, 2024
7567ea7
chore: `pub` ecosystem is no-longer in beta status
bednar Nov 20, 2024
16c232c
docs: update CHANGELOG.md
bednar Nov 20, 2024
3dae00a
chore: remove useless comment
bednar Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ commands:
- checkout
- restore_cache:
keys:
- v1.5-dependencies-{{ arch }}-{{ checksum "pubspec.lock" }}
- v1.5-dependencies-{{ arch }}-
- v1.6-dependencies-{{ arch }}-{{ checksum "pubspec.yaml" }}
- v1.6-dependencies-{{ arch }}-
- run:
name: Download deps
shell: << parameters.shell >>
Expand All @@ -43,7 +43,7 @@ commands:
shell: << parameters.shell >>
command: dart pub global activate junitreport
- save_cache:
key: v1.5-dependencies-{{ arch }}-{{ checksum "pubspec.lock" }}
key: v1.6-dependencies-{{ arch }}-{{ checksum "pubspec.yaml" }}
paths:
- .dart_tool
- << parameters.pub-cache >>
Expand Down Expand Up @@ -243,7 +243,7 @@ jobs:

build-linux:
machine:
image: ubuntu-2004:202201-02
image: ubuntu-2204:current
steps:
- run:
name: Install Dart SDK
Expand Down
1 change: 0 additions & 1 deletion .github/dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
version: 2
enable-beta-ecosystems: true
updates:
- package-ecosystem: "pub"
directory: "/"
Expand Down
2 changes: 1 addition & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
.packages
build/
# If you're building an application, you may want to check-in your pubspec.lock
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So if pubspec.lock is being ignored, does this comment still make sense? My understanding is that pubspec.lock gets generated locally based on pubspec.yaml and that not every generated pubspec.lock will be universally portable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right I will remove this comment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

#pubspec.lock
pubspec.lock

# Directory created by dartdoc
# If you don't generate documentation locally you can remove this line.
Expand Down
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
## 2.11.0 [unreleased]

### Dependencies
1. [#151](https://github.com/influxdata/influxdb-client-dart/pull/151): `intl` package isn't required

### CI
1. [#151](https://github.com/influxdata/influxdb-client-dart/pull/151): CI pipeline supports Dart 2 and 3

## 2.10.0 [2024-06-24]

Explicitly set supported platforms to `android`, `ios`, `linux`, `macos`, `windows`, and `web` to avoid issues with unsupported platforms.
Expand Down
2 changes: 0 additions & 2 deletions lib/api.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import 'dart:math' as math;
import 'package:archive/archive.dart';
import 'package:csv/csv.dart';
import 'package:http/http.dart';
import 'package:intl/intl.dart';
import 'package:meta/meta.dart';
import 'package:universal_io/io.dart';

Expand Down Expand Up @@ -171,7 +170,6 @@ part 'client/retry.dart';

const _delimiters = {'csv': ',', 'ssv': ' ', 'tsv': '\t', 'pipes': '|'};
const _dateEpochMarker = 'epoch';
final _dateFormatter = DateFormat('yyyy-MM-dd');
final _regList = RegExp(r'^List<(.*)>$');
final _regSet = RegExp(r'^Set<(.*)>$');
final _regMap = RegExp(r'^Map<String,(.*)>$');
Expand Down
Loading