Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: publish PackageSet on Fluvio Publish #3694

Merged
merged 5 commits into from
Nov 13, 2023
Merged

feat: publish PackageSet on Fluvio Publish #3694

merged 5 commits into from
Nov 13, 2023

Conversation

EstebanBorai
Copy link
Contributor

@EstebanBorai EstebanBorai commented Nov 13, 2023 •
edited
Loading

Publishes PackageSets as part of bumping Fluvio version.

digikata
digikata approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@digikata digikata left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed during pair prog

@EstebanBorai EstebanBorai requested a review from tjtelan November 13, 2023 19:17
@EstebanBorai EstebanBorai marked this pull request as ready for review November 13, 2023 19:17
tjtelan
tjtelan approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@tjtelan tjtelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some reservations, but I don't feel strongly enough to block on it

makefiles/release.mk Outdated Show resolved Hide resolved
makefiles/release.mk Outdated Show resolved Hide resolved
@EstebanBorai EstebanBorai added this pull request to the merge queue Nov 13, 2023
Merged via the queue into infinyon:master with commit 86fbb94 Nov 13, 2023
104 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjtelan tjtelan tjtelan approved these changes

@digikata digikata digikata approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EstebanBorai @digikata @tjtelan