Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use individual cli test retries #3676

Merged
merged 1 commit into from
Nov 10, 2023
Merged

chore: use individual cli test retries #3676

merged 1 commit into from
Nov 10, 2023

Conversation

galibey
Copy link
Contributor

@galibey galibey commented Nov 9, 2023

Currently, if we use nick-fields/retry retries for cli tests it restarts the entire test suite on a failure. In PR we leverage BATS_TEST_RETRIES which allows to configure retries for an individual test which is more effective.

@galibey galibey requested a review from digikata November 9, 2023 10:31
@galibey galibey self-assigned this Nov 9, 2023
Copy link
Contributor

@digikata digikata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable to me, let's merge it!

Copy link
Contributor

@tjtelan tjtelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a nice improvement. I didn't know about this setting in bats

@tjtelan tjtelan enabled auto-merge November 9, 2023 23:55
@tjtelan tjtelan added this pull request to the merge queue Nov 10, 2023
Merged via the queue into infinyon:master with commit 3473f80 Nov 10, 2023
104 checks passed
@galibey galibey deleted the feat/cli-tests-individual-retries branch November 10, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants