feat: use installation type in cli commands #3675
Conversation
galibey
changed the title
| #[arg(long)] | ||
| no_k8: bool, | ||
| } | ||
| pub struct ShutdownOpt; |
There was a problem hiding this comment.
Are the any cases where a manual override of the recorded installation_type might be needed?
There was a problem hiding this comment.
There should not be any cases when you install one type and want to override it for delete or shutdown.
But, if there is a need for a hack, it can be done by creating a profile fluvio profile add some_profile localhost:1234 local-k8 with setting another installation type and then execute delete or shutdown.
| } | ||
| if s.eq_ignore_ascii_case("readonly") { | ||
| return Ok(Self::ReadOnly); | ||
| } |
There was a problem hiding this comment.
Should these different spelling variations be allowed in the installation type parsing from str?
Docs and configs should really only have one spelling to reduce confusion.
There was a problem hiding this comment.
This is involved in the only place where we pass the installation type as an input:
fluvio profile add <PROFILE_NAME> <CLUSTER_ADDRESS> [INSTALLATION_TYPE]
and while using it I realized that I didn't want to remember if it should be local-k8 or local_k8 etc. So, I added support for all of them.
However, in start command:
fluvio cluster start --local-k8
it is a CLI argument with --, so it only supports one form.
This reverts commit 3d87bf1. CI was unstable when this was merged, need to revert to get back to a stable master
Installation type (Local, LocalK8, K8, ReadOnly) will be stored in the profile after
fluvio cluster start --local/k8/local-k8/read-onlyand will be used in other cluster operations, so, the user does need to specify it onfluvio cluster delete/shutdown/diagnostics