fix: properly propagate sm errors on produce #3671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sehz
reviewed
Nov 7, 2023
| &mut batches, | ||
| std::usize::MAX, | ||
| ctx.metrics().chain_metrics(), | ||
| ) { | ||
| Ok((result, sm_runtime_error)) => { | ||
| if let Some(error) = sm_runtime_error { | ||
| return Err(anyhow!("smartmodule runtime error: {error}")); |
There was a problem hiding this comment.
Instead of trying to revert changes from moving to Anyhow, let's try to find out why this was not caught since we may similar problem elsewhere.
There was a problem hiding this comment.
This is not reverting from anyhow. It is just an error has to be put to PartitionWriteResult to be properly handled on the client side. The type that PartitionWriteResult holds is ErrorCode and I removed unnecessary ErrorCode -> Anyhow::Error -> ErrorCode conversions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, errors related to SM on produce requests are not properly propagated to the Fluvio client. It leads to the produce request just hanging and is killed by timeout. This includes when smartmodule does not exist but is used in transformation.