Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check if custom spu exists on start #3668

Merged
merged 1 commit into from
Nov 8, 2023
Merged

fix: check if custom spu exists on start #3668

merged 1 commit into from
Nov 8, 2023

Conversation

galibey
Copy link
Contributor

@galibey galibey commented Nov 6, 2023 •
edited
Loading

During the local cluster start we check and do not create a new one if CustomSpu already exists. This allows to resume local after shutdown. So, one could do:

fluvio cluster start --local
//insert some data
fluvio cluster shutdown --local
//processes killed but metadata preserved
fluvio cluster start --local
//cluster started with existing metadata and data

Additionally, I changed the order of where to look up fluvio external command. Now, the same folder where the current executable is the first one. It is convenient for local development (you want fluvio-run from your workspace not in fluvio home dir) and for CI tasks where we use two versions of fluvio (stable and dev).

@galibey galibey requested a review from digikata November 6, 2023 16:14
@galibey galibey self-assigned this Nov 6, 2023
@galibey galibey added the CLI label Nov 6, 2023
@galibey galibey requested a review from tjtelan November 6, 2023 16:15
digikata
digikata approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@digikata digikata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sehz
sehz reviewed Nov 6, 2023
View reviewed changes
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, we should have upsert (or apply). But it is good enough for now

@galibey
Copy link
Contributor Author

galibey commented Nov 6, 2023

bors r+

1 similar comment
@galibey
Copy link
Contributor Author

galibey commented Nov 6, 2023

bors r+

@morenol
Copy link
Contributor

morenol commented Nov 6, 2023

bors ping

2 similar comments
@morenol
Copy link
Contributor

morenol commented Nov 6, 2023

bors ping

@galibey
Copy link
Contributor Author

galibey commented Nov 7, 2023

bors ping

@galibey galibey added this pull request to the merge queue Nov 8, 2023
Merged via the queue into infinyon:master with commit 8883d8b Nov 8, 2023
@galibey galibey deleted the feat/support-start-after-shutdown-for-local branch November 8, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sehz sehz sehz left review comments

@digikata digikata digikata approved these changes

@tjtelan tjtelan Awaiting requested review from tjtelan

Assignees

@galibey galibey

Labels
CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@galibey @morenol @digikata @sehz