Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for custom metadata in cluster configuration #3667

Merged
merged 5 commits into from
Nov 9, 2023
Merged

feat: add support for custom metadata in cluster configuration #3667

merged 5 commits into from
Nov 9, 2023

Conversation

matheus-consoli
Copy link
Contributor

@matheus-consoli matheus-consoli commented Nov 3, 2023 •
edited
Loading

Add support for custom metadata in the cluster configuration.

[cluster.name.metadata.installation]
type = "local"

[cluster.name.metadata.dict]
key = "value"

Metadata is managed with two functions:

cluster.query_metadata_path("installation");

struct Example {
    key: String,
}

cluster.update_metadata_path("other_example", Example { key: "value".to_owned() });

Reopening #3628 after reverting at #3666

This was referenced Nov 3, 2023
Closed
Closed
sehz
sehz requested changes Nov 3, 2023
View reviewed changes
crates/fluvio/src/config/cluster.rs Outdated Show resolved Hide resolved
crates/fluvio/src/config/cluster.rs Outdated Show resolved Hide resolved
crates/fluvio/src/config/cluster.rs Show resolved Hide resolved
crates/fluvio/src/config/cluster.rs Outdated Show resolved Hide resolved
@matheus-consoli matheus-consoli force-pushed the feature-cluster-metadata branch from fa3c7c7 to 754f096 Compare November 9, 2023 00:33
@matheus-consoli matheus-consoli requested a review from sehz November 9, 2023 00:36
sehz
sehz approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@sehz sehz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice job!

@matheus-consoli matheus-consoli force-pushed the feature-cluster-metadata branch from 754f096 to a3cfc4d Compare November 9, 2023 00:47
@matheus-consoli
Copy link
Contributor Author

force-pushed a rebase with master

@matheus-consoli matheus-consoli added this pull request to the merge queue Nov 9, 2023
@matheus-consoli matheus-consoli force-pushed the feature-cluster-metadata branch from a3cfc4d to 4ba880a Compare November 9, 2023 01:10
Merged via the queue into infinyon:master with commit f4b9622 Nov 9, 2023
@matheus-consoli matheus-consoli deleted the feature-cluster-metadata branch November 9, 2023 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nacardin nacardin nacardin approved these changes

@sehz sehz sehz approved these changes

@galibey galibey Awaiting requested review from galibey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matheus-consoli @sehz @nacardin